You Have To Put The Feedback for the DLC In The Beta Thread

I've seen already 3 times "Undead" Ravens in floor 1, they have their health bar completely black and tooltip says they are dead, but they move and attack. Their animation also doesn't loop properly

 

Have an issue with item description on traps, when in your inventory the "Item" tag and the actual description were overlapping. Seems to be happening randomly.

 

I've noticed that when trying to sell traps to brax, that seems to trigger it all the time

EDIT: found a couple typos, one in Alchemical Toxic Canister (you toss a crafted an alchemical grenade) and Sonic Wand (causes enemies to drop thier defenses)

 

Mac version?

 

The craftDB.xml file has an incorrect end tag for the document element. It should be </craftDB> not <craftDB/>.

In roomDB.xml, line 3536, the end tag for the room is missing.

In monDB.xml, lime 446, there's an extra <monDB> element.

 

Acidical Projector leaves a cloud of acid which does damage even after the acid cloud is no longer visible. Might want to make the visual effect last as long as the damaging effect.

 

Here are 3 bugs I have found:

1) Recipe (Tinker) - Clockwork Thunderclap - Great Warhammer, blank, blank, Brass Mechanisms.

2) Recipe (Tinker) - Clockwork Ravager - Clockwork Chainaxe, Clockwork Chainaxe, blank, blank.

3) Rocket-powered Punch of Clockwork Knight uses 2 mana when I use it but doesn't show that it uses mana.

Looks great.

 

Oh yeah, here are some old store problems. Not sure if they were going to be fixed with this or not, but here they are.

1) Stacked items show incorrect purchase amount.

2) If you have some of a stacked item in your inventory, you can just pick up the same items from the store and not bother paying for them.

 

Here's a list of semantic XML bugs that are from the new mod content, or still in the core game or RotDG. I'm also going to merge existing bugs from my other XML Bug thread, so they're all in one place.

\expansion2\game\itemDB.xml

Lines 148, 155, 162: These items have artifact="1=" instead of artifact="1"​

​

\expansion2\game\spellDB.xml

Lines 1350, 1357, 1364, 1371, 1378, 1385, 1392, 1399, 1406: These spell buffs are using turns="N" instead of time="N". It's only these spell, so I think it's a bug instead of new, alternate syntax. Effects use "turns". Buffs use "time". That is, unless you now enabled the "turn" syntax for buffs as well.​

​

\expansion\game\itemDB.xml

Line 884: "percentage" is misspelled as "percent":​

<crossbowShotBuff percent="100" name="Ignition Bolt"/>​

​

Line 268,276: Mask of the Golden God has two artifact elements.​

<artifact quality="2" />​

<artifact quality="4"/>​

​

Lines 124, 129, 134: These new reagents aren't marked with alchemical="1".​

They do appear as "Reagent" in the game, so I'm not sure if this attribute is actually important. However, for consistency it would be good if they were marked in the same way as all of the other reagents.​

​

(Actually, this doesn't matter. I just assume that an item without any type information is a reagent, which is exactly what the game does. The only real use for the alchemical attribute is to differentiate gems from runes. Have you considered making an explicit <rune/> element and eliminating "alchemical" altogether?)​

​

\game\spellDB.xml

Line 4075: The Fountain of Ammo spell has template="100" instead of templateID="100"​

Lines 1729, 1736, 1744, 1753, 1762, 1778: These Arcane Capacitor buffs have removeable="0" instead of removable="0"​

​

Line 1267: The halo for "The Recursive Curse" has bad="1". I don't see how a halo sprite can be "bad".​

​

Lines 1436, 1450: "resistances" doesn't appear to be a valid element. It should be resistBuff.​

<resistances necromantic="-2" />​

<resistances necromantic="-1" />​

​

\expansion\game\spellDB.xml

Line 420: Same issue with "resistances".​

​

\game\itemDB.xml

​

Line 518: Three-Pronged Sword is missing type="0" which identifies it as a sword. EDIT: It turns out that if this is missing then it defaults to sword, anyway.​

​

Line 379: Make Puffballs has two <anim> elements.​

<anim sprite="sprites/sfx/glintA/glintA" frames="5" framerate="60" centerEffect="0" sfx="pong" />​

<anim sprite="sprites/sfx/psionic_generic/psionic_generic" frames="5" framerate="100" centerEffect="1"/>​

​

​

 

Wait...Mage's Mana Maille stacks? I could've sworn that no-stacking was the default for buffs. Oops!

 

As part of my current project I'm going to make an XML file validator. All I have now is a tool that generates a plain text schema based on the XML files. Using that I can eyeball bugs like these. It's easy to see when there's a misspelled attribute, or one that contains unexpected values. E.g. the "artifact" attribute being parsed as a string of length 2 instead of a boolean. Then it's just a matter of writing a regular expression to find where it's longer than one character. Still, that's a fair amount of work, and if we had a tool that validated against a known schema, it would be much easier. So, that's the plan.

Here's an example of the schema I generate. Elements have no prefix and are followed by the maximum number of times they appear under their parent element. Attributes are prefixed with @ and appear under their element. They have a database type that I inferred by examining every possible value. (I hard-code attributes that look like paths to 255 length character strings. Other than that the length comes from the longest current value, but in reality I'm just giving things arbitrarily long lengths.)

You can see fun things like "dmgMax" on the weapon element? Really, damage max? What has that? Spoiler: it's Throwing Star. And "maxstack". I'm pretty sure that's defunct now.

This one's generated from the core game, RotDG, and about 10 mods I have installed, all merged together.

Code:

item(968)
  @alchemical bit
  @artifact bit
  @craftoutput bit
  @iconFile varchar( 255 )
  @level int
  @maxstack int
  @name varchar(55)
  @overrideClassName varchar(16)
  @special bit
  @type int
  armour(1)
    @level int
    @randoms bit
    @type varchar(6)
  artifact(1)
    @quality int
  blockBuff(1)
    @name varchar(17)
    @percentage int
  casts(1)
    @spell varchar(26)
  criticalBuff(1)
    @name varchar(14)
    @percentage int
  crossbowShotBuff(2)
    @name varchar(23)
    @percentage int
  damagebuff(1)
    @acidic int
    @aethereal int
    @asphyxiative int
    @blasting int
    @conflagratory int
    @crushing int
    @existential int
    @hyperborean int
    @necromantic int
    @piercing int
    @putrefying int
    @righteous int
    @slashing bit
    @toxic int
    @transmutative int
    @voltaic int
  description(1)
    @text varchar(516)
  food(1)
    @effect varchar(22)
    @hp int
    @meat bit
    @mp int
  gem(1)
  mushroom(1)
  playerHitEffectBuff(1)
    @name varchar(27)
    @percentage int
  potion(1)
    @spell varchar(26)
  price(1)
    @amount int
  primarybuff(6)
    @amount int
    @id int
  resistbuff(3)
    @acidic int
    @aethereal int
    @asphyxiative int
    @athereal int
    @blasting int
    @conflagratory int
    @crushing int
    @existential int
    @hyperborean int
    @necromantic int
    @piercing int
    @putrefying int
    @righteous int
    @slashing int
    @toxic int
    @transmutative int
    @voltaic int
  secondarybuff(22)
    @amount int
    @id int
  targetHitEffectBuff(4)
    @name varchar(26)
    @percentage int
    @taxa varchar(5)
  targetKillBuff(1)
    @name varchar(18)
    @percentage int
    @taxa varchar(9)
  thrownBuff(1)
    @name varchar(22)
    @percentage int
  toolkit(1)
    @active varchar( 255 )
    @autofillbutton varchar(29)
    @autofillbuttonposx int
    @autofillbuttonposy int
    @bg varchar( 255 )
    @closex int
    @closey bit
    @craftbutton varchar(32)
    @craftbuttonposx int
    @craftbuttonposy int
    @missing varchar( 255 )
    @numslots int
    @output_x1 int
    @output_x2 int
    @output_y1 int
    @output_y2 int
    @present varchar( 255 )
    @recipebutton varchar(30)
    @recipebuttonposx int
    @recipebuttonposy int
    @slot1_x1 int
    @slot1_x2 int
    @slot1_y1 int
    @slot1_y2 int
    @slot2_x1 int
    @slot2_x2 int
    @slot2_y1 int
    @slot2_y2 int
    @slot3_x1 int
    @slot3_x2 int
    @slot3_y1 int
    @slot3_y2 int
    @slot4_x1 int
    @slot4_x2 int
    @slot4_y1 int
    @slot4_y2 int
    @sound varchar(11)
    @tag varchar(8)
  trap(1)
    @casts varchar(27)
    @level int
    @origin varchar( 255 )
    @originFacing varchar(5)
    @originMount varchar(4)
    @trigger varchar(6)
  triggerondodge(1)
    @name varchar(17)
    @percentage int
  wand(1)
    @maxcharge int
    @mincharge int
    @spell varchar(27)
  weapon(2)
    @acidic int
    @aethereal int
    @asphyxiative int
    @blasting int
    @cantargetfloor bit
    @conflagratory int
    @crushing int
    @dmgMax int
    @existential int
    @hit varchar(23)
    @hyperborean int
    @necromantic int
    @piercing int
    @putrefying int
    @putrifying int
    @righteous int
    @slashing int
    @thrown varchar( 255 )
    @toxic int
    @transmutative int
    @voltaic int
power(21)
  @description varchar(52)
  @name varchar(18)
  @spell varchar(22)

 

Saw a raven set off a shardspitter. Might need to give them flying.